From c5b61a3294ef593fa93bafa01a76b1c284922097 Mon Sep 17 00:00:00 2001 From: Vladimir Eremin Date: Sun, 5 Jul 2026 11:20:25 +0300 Subject: [PATCH] fix: exclude commons/ from dclint --fix to prevent submodule dirtying In node repos the shared core compose lives inside the pinned commons submodule; letting dclint rewrite it dirties the submodule, which makes sync/repository abort the nightly capture-up. Harmless in the standalone commons repo (no commons/ dir). --- actions/utils/lint-docker-compose.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/actions/utils/lint-docker-compose.py b/actions/utils/lint-docker-compose.py index 08fea2d..78f3a9e 100644 --- a/actions/utils/lint-docker-compose.py +++ b/actions/utils/lint-docker-compose.py @@ -26,9 +26,11 @@ def run(ctx, args): targets = [f"/workdir/{f}" for f in files_string.splitlines()] log.info("Running dclint --fix (via docker)...") + # "-e commons": never --fix inside the pinned submodule — a dirtied commons makes + # sync/repository abort the nightly capture-up. r = s.run(["docker", "run", "--rm", "-v", f"{repo}:/workdir", "-w", "/workdir", "node:lts-alpine", "npx", "--yes", "dclint", "-e", "@tier1", "-e", "@tier2", "-e", "@tier3", "-e", ".env", - "-r", "--fix", *targets], check=False) + "-e", "commons", "-r", "--fix", *targets], check=False) if r.returncode != 0: log.error(f"dclint issues (exit {r.returncode})."); return r.returncode or rc_ip if args.hook and files_string: